upspin, client, cmd/upspinfs: change signature of client.Rename

client.Rename renames a file. Under the covers, it creates and
packs a new DirEntry for the new name, Puts it, and then Deletes
the old entry. Like Put, it should have been changed to return
the new DirEntry to allow upspinfs and other Watchers to serialize
their own actions and incoming WatchEvents.

Also, a lock was missing in upspinfs's Rename exacerbating the
problem since it caused unsynchronized parallelism between the
Rename and the resulting WatchEvents.

Fixes #586

Change-Id: Iadfccd57b19db18e2f52bed6d00e3a6a89694d77
Reviewed-on: https://upspin-review.googlesource.com/18940
Reviewed-by: Andrew Gerrand <adg@golang.org>
6 files changed
tree: 9b66a45a7bfa64226405371ddbd1845a8499d271
  1. .travis.yml
  2. AUTHORS
  3. CONDUCT.md
  4. CONTRIBUTING.md
  5. CONTRIBUTORS
  6. Gopkg.lock
  7. Gopkg.toml
  8. LICENSE
  9. PATENTS
  10. README.binary
  11. README.md
  12. access/
  13. bind/
  14. cache/
  15. client/
  16. cloud/
  17. cmd/
  18. config/
  19. dir/
  20. doc/
  21. errors/
  22. factotum/
  23. flags/
  24. key/
  25. log/
  26. metric/
  27. pack/
  28. path/
  29. rpc/
  30. serverutil/
  31. shutdown/
  32. store/
  33. subcmd/
  34. test/
  35. transports/
  36. upbox/
  37. upspin/
  38. user/
  39. valid/
  40. vendor/
  41. version/
README.md

Upspin

Augie

Documentation: upspin.io

About the project

Upspin is an experimental project to build a framework for naming and sharing files and other data securely, uniformly, and globally: a global name system of sorts.

It is not a file system, but a set of protocols and reference implementations that can be used to join things like file systems and other storage services to the name space.

Performance is not a primary goal. Uniformity and security are.

Upspin is not an official Google product.

Status

Upspin has rough edges, and is not yet suitable for non-technical users.

Build Status

Contributing

The code repository lives at upspin.googlesource.com and is mirrored to GitHub.

Note that the Upspin project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only.

See the Contribution Guidelines for more information on contributing to the project.

Reporting issues

Please report issues through our issue tracker.

Community

All Upspin users should subscribe to the Upspin Announcements mailing list to receive critical information about the project.

Use the Upspin mailing list for discussion about Upspin use and development.

Code of Conduct

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

The Upspin mascot is Copyright 2017 Renee French. All Rights Reserved.